Add unit test for gRPC over h1, negotiated by TLS+ALPN #2216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: ServiceTalk can do gRPC over HTTP/1.x, and it can negotiate protocols with TLS via ALPN. This isn't expected to be commonly used in practice but is possible given the layering of transports below protocol.
bondolo
approved these changes
May 16, 2022
| private static final HttpProtocolConfig[] H2H1 = new HttpProtocolConfig[] {h2Default(), h1Default()}; | ||
|
|
||
| private enum ProtocolTestMode { | ||
| ServerH1_ClientH1H2(H1, H1H2), |
There was a problem hiding this comment.
Is it perhaps worth testing the ServerH1_ClientH1 case?
There was a problem hiding this comment.
With h1-h1 there will be no ALPN involved, but should still work. Testing it won't harm for sure
idelpivnitskiy
approved these changes
May 16, 2022
| private static final HttpProtocolConfig[] H2H1 = new HttpProtocolConfig[] {h2Default(), h1Default()}; | ||
|
|
||
| private enum ProtocolTestMode { | ||
| ServerH1_ClientH1H2(H1, H1H2), |
There was a problem hiding this comment.
With h1-h1 there will be no ALPN involved, but should still work. Testing it won't harm for sure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
ServiceTalk can do gRPC over HTTP/1.x, and it can negotiate
protocols with TLS via ALPN. This isn't expected to be commonly
used in practice but is possible given the layering of transports
below protocol.