Migrate ON_CONNECTION_SELECTED_CONSUMER to request context
#2239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: `AbstractLifecycleObserverHttpFilter` uses a secret `ON_CONNECTION_SELECTED_CONSUMER` context key to capture the selected connection down the processing chain. Instead of relying on `AsyncContext` that can be disabled, we can use a context of the request. Modifications: - Store `ON_CONNECTION_SELECTED_CONSUMER` in `request.context()` instead of `AsyncContext`; - Use `Runnable` to clear the key on exchange finally; Result: `AbstractLifecycleObserverHttpFilter` will report `onConnectionSelected` even if `AsyncContext` is disabled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
AbstractLifecycleObserverHttpFilteruses a secretON_CONNECTION_SELECTED_CONSUMERcontext key to capture the selectedconnection down the processing chain. Instead of relying on
AsyncContextthat can be disabled, we can use a context of the request.Modifications:
ON_CONNECTION_SELECTED_CONSUMERinrequest.context()insteadof
AsyncContext;Runnableto clear the key on exchange finally;Result:
AbstractLifecycleObserverHttpFilterwill reportonConnectionSelectedeven if
AsyncContextis disabled.