Cancellation can leave an HTTP/1.x connection in half-closed state #2264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: If a response is cancelled at the connection level (skipping explicit closure of the connection in `LoadBalancedStreamingHttpClient`), it will hang in half-closed state (inbound closed) if the server doesn't proceed with sending more bytes on that connection (outbound will never be closed). Also, cancellation marks the connection as `CHANNEL_CLOSED_INBOUND`, which is misleading because the closure is initiated by the client. Modifications: - Enhance `ResponseCancelTest` to verify the described scenario; - Adjust `NettyChannelPublisher` to close both outbound (first, to correctly mark the connection close reason) and inbound; Result: Cancelled HTTP/1.x connection is always closed correctly.
Scottmitch
approved these changes
Jul 14, 2022
servicetalk-http-netty/src/test/java/io/servicetalk/http/netty/ResponseCancelTest.java
Outdated
Show resolved
Hide resolved
servicetalk-http-netty/src/test/java/io/servicetalk/http/netty/ResponseCancelTest.java
Show resolved
Hide resolved
servicetalk-http-netty/src/test/java/io/servicetalk/http/netty/ResponseCancelTest.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
If a response is canceled at the connection level (skipping explicit
closure of the connection in
LoadBalancedStreamingHttpClient), it willhang in a half-closed state (inbound closed) if the server doesn't proceed
with sending more bytes on that connection (outbound will never be
closed). Also, cancellation marks the connection as
CHANNEL_CLOSED_INBOUND, which is misleading because the closure isinitiated by the client.
Modifications:
ResponseCancelTestto verify the described scenario;NettyChannelPublisherto close both outbound (first, tocorrectly mark the connection close reason) and inbound;
Result:
Canceled HTTP/1.x connection is always closed correctly.