AsciiBuffer.indexOf returns incorrect result for 2-bytes characters
#2352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: `AsciiBuffer.indexOf` casts `char` to `byte` by dropping the higher 8 bits. As the result, it may return an index of an ascii character that has the same lower 8 bits. Modifications: - Check character length and return `-1` if it's 2-bytes character; Result: Correct result when users try to find an index of a 2-bytes character in `AsciiBuffer`. Consistency with other `CharSequence` implementations, like `String` and `StringBuilder`.
Scottmitch
approved these changes
Sep 10, 2022
| @@ -114,9 +114,16 @@ Buffer unwrap() { | |||
| * @throws NullPointerException if {@code subString} is {@code null}. | |||
| */ | |||
| int indexOf(char ch, int start) { | |||
| if (!singleByte(ch)) { | |||
| return -1; | |||
| } | |||
| return buffer.indexOf(start, buffer.writerIndex(), (byte) ch); | |||
There was a problem hiding this comment.
nit: simplify and remove negation: return singleByte(ch) ? buffer.indexOf(start, buffer.writerIndex(), (byte) ch) : -1;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
AsciiBuffer.indexOfcastschartobyteby dropping the higher 8 bits. As the result, it may return an index of an ascii character that has the same lower 8 bits.Modifications:
-1if it's 2-bytes character;Result:
Correct result when users try to find an index of a 2-bytes character in
AsciiBuffer. Consistency with otherCharSequenceimplementations, likeStringandStringBuilder.