Single#concatPropagateCancel(Publisher) to force cancel propagation #2381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
servicetalk-concurrent-api/src/main/java/io/servicetalk/concurrent/api/Single.java
Outdated
Show resolved
Hide resolved
Motivation: In some scenarios concat is used where the right hand side has assocated state that is desirable to always trigger (concat payload body to meta data for http response processing). Regular concat will not subscribe if the Single terminates with onError or is cancelled which will prevent terminal event visibility.
Scottmitch
force-pushed
the
single_concat_pub
branch
from
2bc3ccd to
ed2c50b
Compare
Scottmitch
changed the title
servicetalk-concurrent-api/src/main/java/io/servicetalk/concurrent/api/Single.java
Show resolved
Hide resolved
servicetalk-concurrent-api/src/main/java/io/servicetalk/concurrent/api/Single.java
Outdated
Show resolved
Hide resolved
...rrent/reactivestreams/tck/SingleConcatWithPublisherDeferSubscribePropagateCancelTckTest.java
Outdated
Show resolved
Hide resolved
...nt-api/src/test/java/io/servicetalk/concurrent/api/single/SingleConcatWithPublisherTest.java
Outdated
Show resolved
Hide resolved
...lk-concurrent-api/src/main/java/io/servicetalk/concurrent/api/SingleConcatWithPublisher.java
Outdated
Show resolved
Hide resolved
...lk-concurrent-api/src/main/java/io/servicetalk/concurrent/api/SingleConcatWithPublisher.java
Outdated
Show resolved
Hide resolved
|
Thank you! |
idelpivnitskiy
approved these changes
Oct 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
In some scenarios concat is used where the right hand side has assocated state that is desirable to always trigger (concat payload body to meta data for http response processing). Regular concat will not subscribe if the Single terminates with onError or is cancelled which will prevent terminal event visibility.