RetryingHttpRequesterFilter: drain response before mapping to exception
#2391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion Motivation: `RetryingHttpRequesterFilter` has `responseMapper` feature that helps users to translate some responses into `HttpResponseException`. However, it doesn't drain the response payload body, which will cause connection leaks. Modifications: - Drain response payload body before returning `HttpResponseException`; - Improve tests to verify connections do not leak; - Use `assertThrows` instead of `fail` in tests; Result: Connections do not leak when `responseMapper` feature is used.
tkountis
approved these changes
Oct 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
RetryingHttpRequesterFilterhasresponseMapperfeature that helps users to translate some responses intoHttpResponseException. However, it doesn't drain the response payload body, which will cause connection leaks.Modifications:
HttpResponseException;assertThrowsinstead offailin tests;Result:
Connections do not leak when
responseMapperfeature is used.