Buffer.[set|write]Bytes doesn't return -1 after EOF
#2395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: apple#2389 introduced a bug for `Buffer.[set|write]Bytes` methods that returns `0` instead of `-1` after EOF. Modifications: - Make sure we preserve `-1` signal if nothing else was read from the `InputStream`; Result: `Buffer.[set|write]Bytes` correctly return `-1` after EOF.
tkountis
approved these changes
Oct 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
#2389 introduced a bug for
Buffer.[set|write]Bytesmethods that returns0instead of-1after EOF.Modifications:
-1signal if nothing else was read from theInputStream;Result:
Buffer.[set|write]Bytescorrectly return-1after EOF.