Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

H2 conversion support OWS for connection header csv #2400

Merged
merged 2 commits into from
Oct 20, 2022

Conversation

Scottmitch
Copy link
Member

Motivation:
H2 doesn't support the connection header, and must remove all headers that are referenced in the value of the conneciton header. In the event the connection header contains a CSV we should support OWS.

@Scottmitch Scottmitch marked this pull request as ready for review October 17, 2022 00:03
Copy link
Member

@idelpivnitskiy idelpivnitskiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider testing with DefaultHttpHeadersFactory when h2PriorKnowledge == true.
Reminder that in Netty 4.1.84 DefaultHttp2Headers will throw if someone tries to add a Connection header.

Motivation:
H2 doesn't support the connection header, and must remove
all headers that are referenced in the value of the conneciton
header. In the event the connection header contains a CSV we should
support OWS.
@Scottmitch Scottmitch merged commit 6e56db0 into apple:main Oct 20, 2022
@Scottmitch Scottmitch deleted the h2_conn_hdr_ows branch October 20, 2022 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants