BeforeFinallyHttpOperator: support re-subscribe to the message body
#2409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: `BeforeFinallyHttpOperator` has a single `state` inside `ResponseCompletionSubscriber` that is shared between `Single` and `Publisher` of the message body. If users re-subscribe to the message body, the state is already in `TERMINATED` position and does not propagate signals. Modifications: - Move message body processing logic into a new `MessageBodySubscriber` class; - Each subscribe operation creates a new `MessageBodySubscriber` and their states are managed independently; Result: Users of `BeforeFinallyOperator` always see all terminal events, even for re-subscribe. Terminal signal will always be delivered to the second subscriber, even when `discardEventsAfterCancel` is set.
Scottmitch
approved these changes
Oct 26, 2022
Scottmitch
reviewed
Oct 26, 2022
|
The problem was in the test, it reused a response object which resulted in applying transform on the payload body twice. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
BeforeFinallyHttpOperatorhas a singlestateinsideResponseCompletionSubscriberthat is shared betweenSingleandPublisherof the message body. If users re-subscribe to the message body, the state is already inTERMINATEDposition and does not propagate signals.Modifications:
MessageBodySubscriberclass;MessageBodySubscriberand their states are managed independently;IdleTimeoutConnectionFilterTestto always create a new response object (otherwise, the response payload body can be transformed multiple times);Result:
Users of
BeforeFinallyOperatoralways see all terminal events, even for re-subscribe. Terminal signal will always be delivered to the second subscriber, even whendiscardEventsAfterCancelis set.