Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ScheduledExecutorService to remove timeout objects on cancel #2426

Merged
merged 1 commit into from
Nov 18, 2022
Merged

ScheduledExecutorService to remove timeout objects on cancel #2426

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions servicetalk-concurrent-api/src/main/java/io/servicetalk/concurrent/api/DefaultExecutor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
import java.util.concurrent.RejectedExecutionHandler;
import java.util.concurrent.ScheduledExecutorService;
import java.util.concurrent.ScheduledFuture;
import java.util.concurrent.ScheduledThreadPoolExecutor;
import java.util.concurrent.SynchronousQueue;
import java.util.concurrent.ThreadFactory;
import java.util.concurrent.ThreadPoolExecutor;
Expand All @@ -36,9 +37,8 @@
import javax.annotation.Nullable;

import static io.servicetalk.concurrent.Cancellable.IGNORE_CANCEL;
import static io.servicetalk.utils.internal.PlatformDependent.throwException;
import static io.servicetalk.utils.internal.ThrowableUtils.throwException;
import static java.lang.Thread.NORM_PRIORITY;
import static java.util.concurrent.Executors.newSingleThreadScheduledExecutor;
import static java.util.concurrent.TimeUnit.SECONDS;

/**
Expand All @@ -53,14 +53,21 @@ final class DefaultExecutor extends AbstractExecutor implements Consumer<Runnabl
* scheduler thread is usually ok. In cases, when it is not, one can always override the executor with a custom
* scheduler.
*/
private static final ScheduledExecutorService GLOBAL_SINGLE_THREADED_SCHEDULED_EXECUTOR =
newSingleThreadScheduledExecutor(new DefaultThreadFactory("servicetalk-global-scheduler",
private static final ScheduledThreadPoolExecutor GLOBAL_SINGLE_THREADED_SCHEDULED_EXECUTOR =
new ScheduledThreadPoolExecutor(1, new DefaultThreadFactory("servicetalk-global-scheduler",
true, NORM_PRIORITY));
private static final RejectedExecutionHandler DEFAULT_REJECTION_HANDLER = new AbortPolicy();

private final InternalExecutor executor;
private final InternalScheduler scheduler;

static {
// It isn't uncommon to set timers for longer intervals that required and cancel these timers. For example
// each request may have a timeout applied and in the happy path no requests will timeout. We don't need to
// retain timeout objects for their full duration and we should make them eligible for GC asap.
GLOBAL_SINGLE_THREADED_SCHEDULED_EXECUTOR.setRemoveOnCancelPolicy(true);
}

DefaultExecutor(int coreSize, int maxSize, ThreadFactory threadFactory) {
this(new ThreadPoolExecutor(coreSize, maxSize, DEFAULT_KEEP_ALIVE_TIME_SECONDS, SECONDS,
new SynchronousQueue<>(), threadFactory, DEFAULT_REJECTION_HANDLER));
Expand Down