Add mark/reset functionality to BufferInputStream
#2447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobbyowolabi
changed the title
idelpivnitskiy
requested changes
Nov 30, 2022
servicetalk-buffer-api/src/main/java/io/servicetalk/buffer/api/BufferInputStream.java
Outdated
Show resolved
Hide resolved
servicetalk-buffer-api/src/main/java/io/servicetalk/buffer/api/BufferInputStream.java
Outdated
Show resolved
Hide resolved
servicetalk-buffer-api/src/main/java/io/servicetalk/buffer/api/BufferInputStream.java
Outdated
Show resolved
Hide resolved
servicetalk-buffer-api/src/main/java/io/servicetalk/buffer/api/BufferInputStream.java
Outdated
Show resolved
Hide resolved
servicetalk-buffer-api/src/test/java/io/servicetalk/buffer/api/BufferInputStreamTest.java
Outdated
Show resolved
Hide resolved
servicetalk-buffer-api/src/test/java/io/servicetalk/buffer/api/BufferInputStreamTest.java
Outdated
Show resolved
Hide resolved
bobbyowolabi
force-pushed
the
bobbyowolabi/1562-bufferedinputstream-mark-reset-support
branch
3 times, most recently
from
128bdf4 to
c2f1727
Compare
|
Thank you for your time to review and all the feedback. I made updates for all the suggestions. |
Motivation: BufferInputStream can support the mark/reset functionality with not too much additional logic like ByteArrayInputStream and ByteBufInputStream (from netty). Modifications: - Implemented the mark, reset and markSupported methods of BufferInputStream - Added test cases Result: Addresses apple#1562
bobbyowolabi
force-pushed
the
bobbyowolabi/1562-bufferedinputstream-mark-reset-support
branch
from
c2f1727 to
d4454a3
Compare
idelpivnitskiy
changed the title
BufferInputStream
idelpivnitskiy
approved these changes
Dec 2, 2022
There was a problem hiding this comment.
Looks sparkling clean now. Thanks for the contribution, @bobbyowolabi!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
BufferInputStream can support the mark/reset functionality, as noted in #1562, like ByteArrayInputStream and ByteBufInputStream (from netty).
Modifications:
Result:
Resolves #1562.