RetryingHttpRequesterFilter: rename ofImmediate to ofImmediateBounded
#2459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daschl
approved these changes
Dec 9, 2022
…unded` Motivation: It's not obvious for users that `BackOffPolicy.ofImmediate()` retries only 3 times. Modifications: - Deprecated `BackOffPolicy.ofImmediate()`; - Introduce `BackOffPolicy.ofImmediateBounded()` that behaves the same way; - Cache the returning value for `BackOffPolicy.ofImmediateBounded()`; Result: Easier for users to understand that immediate `BackOffPolicy` has a limit for number of retries.
idelpivnitskiy
force-pushed
the
ofImmediate
branch
from
a3c7e6b to
06152bf
Compare
idelpivnitskiy
changed the title
RetryingHttpRequesterFilter: rename ofImmediate to ofImmediateWithDefaultLimitRetryingHttpRequesterFilter: rename ofImmediate to ofImmediateBounded
|
Discussed with @tkountis offline and he recommended another name: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
It's not obvious for users that
BackOffPolicy.ofImmediate()retries only 3 times.Modifications:
BackOffPolicy.ofImmediate();BackOffPolicy.ofImmediateBounded()that behaves the same way;BackOffPolicy.ofImmediateBounded();Result:
Easier for users to understand that immediate
BackOffPolicyhas a limit for number of retries.