Introduce GrpcExecutionStrategies#offloadNone #2478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: To ensure partiy with HttpExecutionStrategies it makes sense to introduce "offloadNone" as a static utility method instead of only making it accessible through a builder. Modifications: This changeset adds the static "offloadNone" utility method in GrpcExecutionStrategies and clarifies the javadoc of "offloadNever" (which is deprecated) on alternative usage. Result: Feature parity between GRPC and HTTP on the "offloadNone" execution strategy creation.
idelpivnitskiy
requested changes
Jan 4, 2023
servicetalk-grpc-api/src/main/java/io/servicetalk/grpc/api/GrpcExecutionStrategies.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
To ensure partiy with HttpExecutionStrategies it makes sense to introduce "offloadNone" as a static utility method instead of only making it accessible through a builder.
Modifications:
This changeset adds the static "offloadNone" utility method in GrpcExecutionStrategies and clarifies the javadoc of "offloadNever" (which is deprecated) on alternative usage.
Result:
Feature parity between GRPC and HTTP on the "offloadNone" execution strategy creation.