Consider request strategy when we schedule timeouts or retries #2482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Currently, timeout and retrying filter uses an `HttpExecutionStrategy` from the `ExecutionContext`. However, on the requester side users can either use a different API that optimizes the pre-computed strategy or they can put a custom strategy per request. Modifications: - For `RetryingHttpRequesterFilter`, compute `alternativeTimerExecutor` based on `HTTP_EXECUTION_STRATEGY_KEY`; - For `TimeoutHttpRequesterFilter`, compute `useForTimeout` based on `HTTP_EXECUTION_STRATEGY_KEY`; - Adjust tests for new behavior; Result: 1. On the client-side, the actual `HttpExecutionStrategy` associated with the request is considered. 2. Less use of offloading executor when there is no need to offload.
idelpivnitskiy
changed the title
daschl
reviewed
Jan 5, 2023
...etalk-http-utils/src/test/java/io/servicetalk/http/utils/TimeoutHttpRequesterFilterTest.java
Show resolved
Hide resolved
daschl
approved these changes
Jan 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Currently, timeout and retrying filter uses an
HttpExecutionStrategyfrom theExecutionContext. However, on the requester side users can either use a different API that optimizes the pre-computed strategy or they can put a custom strategy per request.Modifications:
RetryingHttpRequesterFilter, computealternativeTimerExecutorbased onHTTP_EXECUTION_STRATEGY_KEY;TimeoutHttpRequesterFilter, computeuseForTimeoutbased onHTTP_EXECUTION_STRATEGY_KEY;Result:
HttpExecutionStrategyassociated with the request is considered.