SequentialCancellable: add cancelCurrent() method
#2516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: In scenarios when `SequentialCancellable` is used to manage global cancellation, there might be cases when we have to re-subscribe. Cancelling the current `Cancellable` will allow us to do this. Modifications: - Add `SequentialCancellable#cancelCurrent()` method; - Test the new feature; Result: It's possible to cancel only the current `Cancellable` inside `SequentialCancellable` and then re-subscribe.
2 tasks
daschl
approved these changes
Feb 22, 2023
...current-internal/src/main/java/io/servicetalk/concurrent/internal/SequentialCancellable.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
In scenarios when
SequentialCancellableis used to manage global cancellation, there might be cases when we have to re-subscribe. Cancelling the currentCancellablewill allow us to do this.Modifications:
SequentialCancellable#cancelCurrent()method;Result:
It's possible to cancel only the current
CancellableinsideSequentialCancellableand then re-subscribe.