loadbalancer-experimental: support non-sequential priorities #2953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryce-anderson
force-pushed
the
bl_anderson/support-nonconsecutive-priorities
branch
from
99f6626 to
c20ed4d
Compare
Motivation: We currently don't support priority sets that don't have sequential groups numbers, eg we require groups 0, 1, 2, ... and will reject a set of groups such as 0, 2, 3, ... This is an artificial constraint. Modifications: Lift the constraint.
bryce-anderson
force-pushed
the
bl_anderson/support-nonconsecutive-priorities
branch
from
c20ed4d to
49d3e77
Compare
mgodave
approved these changes
Jun 6, 2024
...ncer-experimental/src/main/java/io/servicetalk/loadbalancer/DefaultHostPriorityStrategy.java
Outdated
Show resolved
Hide resolved
tkountis
approved these changes
Jun 7, 2024
| // What to do if we don't have any healthy nodes at all? | ||
| if (remainingProbability > 0) { | ||
| // TODO: this is an awkward situation. Should we panic and just discard priority information? | ||
| if (weightedResults.isEmpty()) { |
There was a problem hiding this comment.
we should have ways to observe these for our observability story.
There was a problem hiding this comment.
Good point. I'll add a log message for now. If you meant something like an observer then I'm not sure how that would fit nicely but we can look at it as a follow up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
We currently don't support priority sets that don't have sequential
groups numbers, eg we require groups 0, 1, 2, ... and will reject a
set of groups such as 0, 2, 3, ... This is an artificial constraint.
Modifications:
resilient to an adversarial case of getting a group with a large.