loadbalancer-experimental: allow configuring whether cancellation is an error #2956
+75
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…an error Motivation: Cancellation is ambiguous as to why it was cancelled, although it is most likely due to timeouts. We should let users configure this. Modifications: - Make classification of cancellation as an error a configuration option. - Thread it through, including in the providers. Result: More flexible classification of cancellation.
bryce-anderson
commented
Jun 6, 2024
| @@ -317,6 +327,7 @@ public static final class Builder { | |||
| static final Duration DEFAULT_EWMA_HALF_LIFE = Duration.ofSeconds(10); | |||
| static final long DEFAULT_CANCEL_PENALTY = 5L; | |||
| static final long DEFAULT_ERROR_PENALTY = 10L; | |||
| private boolean cancellationIsError; | |||
There was a problem hiding this comment.
I think it's worth considering cancellation to be errors as the default since timeouts will be a very common reason for cancellation. Opinions welcome.
There was a problem hiding this comment.
I did end up changing the default because we already consider cancellation as a half-penalty for the P2C algorithm. Opinions appreciated.
idelpivnitskiy
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Cancellation is ambiguous as to why it was cancelled, although it is most likely due to timeouts. We should let users configure this.
Modifications:
Result:
More flexible classification of cancellation.