Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

concurrent-api: save the timestamp of the SingleToFuture.get() calls #3051

Merged
merged 2 commits into from
Sep 4, 2024
Merged

concurrent-api: save the timestamp of the SingleToFuture.get() calls #3051

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
50ef2ef
concurent-api: save the timestamp of the SingleToFuture.get() calls
bryce-anderson Aug 29, 2024
6bfbba2
Add ms suffix
bryce-anderson Aug 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion servicetalk-concurrent-api/src/main/java/io/servicetalk/concurrent/api/SourceToFuture.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,9 @@ abstract class SourceToFuture<T> implements Future<T> {
@Nullable
private volatile Object value;

// The timestamp of the last `.get()` call. This is intended to help with debugging stuck threads via heap dumps.
private long lastGetTimestampMs;

private SourceToFuture() {
}

Expand Down Expand Up @@ -91,7 +94,12 @@ public final boolean isDone() {
public final T get() throws InterruptedException, ExecutionException {
final Object value = this.value;
if (value == null) {
latch.await();
lastGetTimestampMs = System.currentTimeMillis();
try {
latch.await();
} finally {
lastGetTimestampMs = 0;
}
return reportGet(this.value);
} else {
return reportGet(value);
Expand Down
Loading