TcpServerBinder: don't log "Failed to create a connection" twice
#3113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: `TcpServerBinder` uses `beforeOnError` to log any failures to create a connection (to capture connection info) and then it goes to `SimpleSingleSubscriber` that logs it again. Modifications: - Use new `Single.subscribe(...)` overload that takes `errorConsumer` to log "Failed to create a connection"; - Log full `Channel` info instead of just remote address to keep consistent patter of starting all network-level logs with channel id; Result: Exception is logged only once.
idelpivnitskiy
changed the title
TcpServerBinder logs "Failed to create a connection" twiceTcpServerBinder: don't log "Failed to create a connection" twice
bryce-anderson
approved these changes
Nov 18, 2024
mgodave
approved these changes
Nov 18, 2024
mgodave
pushed a commit
to mgodave/servicetalk
that referenced
this pull request
Nov 19, 2024
) Motivation: `TcpServerBinder` uses `beforeOnError` to log any failures to create a connection (to capture connection info) and then it goes to `SimpleSingleSubscriber` that logs it again. Modifications: - Use new `Single.subscribe(...)` overload that takes `errorConsumer` to log "Failed to create a connection"; - Log full `Channel` info instead of just remote address to keep consistent patter of starting all network-level logs with channel id; Result: Exception is logged only once.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
TcpServerBinderusesbeforeOnErrorto log any failures to create a connection (to capture connection info) and then it goes toSimpleSingleSubscriberthat logs it again.Modifications:
Single.subscribe(...)overload introduced in #3112 that takeserrorConsumerto log "Failed to create a connection";Channelinfo instead of just remote address to keep a consistent pattern of starting all network-level logs with channel id;Result:
Exception is logged only once.