-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add logo, favicon and footer copy #3116
Conversation
thx for the contribution @federicobucchi! there are a few build errors. If you run
More investigation required but you may need to add exclusions for png files:
|
91fe6f5
to
5076f29
Compare
5076f29
to
eb2e2fa
Compare
It succeed in local:
|
...-internal/src/main/groovy/io/servicetalk/gradle/plugin/internal/ServiceTalkCorePlugin.groovy
Outdated
Show resolved
Hide resolved
…alk/gradle/plugin/internal/ServiceTalkCorePlugin.groovy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Idk what's wrong with CodeQL. This PR is definitely good and should not be blocked. I proposed to merge as-is @Scottmitch.
@federicobucchi thank you for the contribution!
Motivation:
Since there is an existing logo, I thought about using it in the UI (on the header and favicon).
Modifications:
Changes on the header and footer.
Visual Changes: