Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding remote info to logger message so clients can be tracked down #3155

Merged
merged 1 commit into from
Jan 14, 2025
Merged

Adding remote info to logger message so clients can be tracked down #3155

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions ...netty/src/main/java/io/servicetalk/http/netty/HttpMessageDiscardWatchdogClientFilter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ public Single<StreamingHttpResponse> request(final StreamingHttpRequest request)
LOGGER.warn("Discovered un-drained HTTP response message body which has " +
"been dropped by user code - this is a strong indication of a bug " +
"in a user-defined filter. Response payload (message) body must " +
"be fully consumed before retrying.");
"be fully consumed before retrying. connectionInfo={}", connectionContext());
}

return response.transformMessageBody(msgPublisher -> msgPublisher.beforeSubscriber(() -> {
Expand Down Expand Up @@ -115,7 +115,8 @@ protected Single<StreamingHttpResponse> request(final StreamingHttpRequester del
LOGGER.warn("Discovered un-drained HTTP response message body which has " +
"been dropped by user code - this is a strong indication of a bug " +
"in a user-defined filter. Response payload (message) body must " +
"be fully consumed before discarding.", cause);
"be fully consumed before discarding. hostAndPort={}",
request.effectiveHostAndPort(), cause);
}
});
}
Expand Down
Loading