Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove special casing for CustomNSError #276

Merged
merged 1 commit into from
Feb 18, 2021
Merged

Remove special casing for CustomNSError #276

merged 1 commit into from
Feb 18, 2021

Conversation

natecook1000
Copy link
Member

@natecook1000 natecook1000 commented Feb 16, 2021 •
edited
Loading

The error code in CustomNSError is actually not appropriate to use as the command's exit code, as described in #269.

Checklist

  • I've added at least one test that validates that my change is working, if appropriate
  • I've followed the code style of the rest of the project
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary

@natecook1000
Remove special casing for CustomNSError
70c7e21 
The error code in CustomNSError is actually _not_ appropriate to use as
the command's exit code.
@natecook1000
Copy link
Member Author

@swift-ci Please test

2 similar comments
@natecook1000
Copy link
Member Author

@swift-ci Please test

@natecook1000
Copy link
Member Author

@swift-ci Please test

@natecook1000 natecook1000 merged commit e5178a9 into main Feb 18, 2021
@natecook1000 natecook1000 deleted the nate/no_more_customnserror branch February 18, 2021 20:03
@swift-ci swift-ci mentioned this pull request Nov 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@natecook1000