Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: correct ordering of include #608

Merged
merged 1 commit into from
Dec 11, 2023
Merged

Conversation

compnerd
Copy link
Collaborator

@compnerd compnerd commented Dec 8, 2023

Correct the ordering that @bnbarham pointed out post-commit. Ensure that we adjust the CMAKE_MODULE_PATH prior to the use of include which will reference local modules.

Correct the ordering that @bnbarham pointed out post-commit.  Ensure
that we adjust the `CMAKE_MODULE_PATH` prior to the use of `include`
which will reference local modules.
@compnerd
Copy link
Collaborator Author

compnerd commented Dec 8, 2023

@rauhul - turns out that I do not have commit access on the repository, I would appreciate it if you could assist with that as well 😀

CC: @bnbarham @xedin

@compnerd
Copy link
Collaborator Author

compnerd commented Dec 8, 2023

@swift-ci please test

@rauhul
Copy link
Contributor

rauhul commented Dec 8, 2023

@rauhul - turns out that I do not have commit access on the repository, I would appreciate it if you could assist with that as well 😀

CC: @bnbarham @xedin

Hmm I don't have the ability to fix that and I don't think Nate can either; I think either @shahmishal or @tkremenek would need change the repo permissions.

In the interim I am happy to press merge on your behalf 😅

@natecook1000
Copy link
Member

LGTM! @compnerd will this require a new release?

@compnerd
Copy link
Collaborator Author

compnerd commented Dec 8, 2023

@natecook1000 - I don't think that the previous change went into 1.3.0, so I think we should be okay. If it did make it into 1.3.0, we should do a 1.3.1.

@compnerd
Copy link
Collaborator Author

@natecook1000, @rauhul - anything else to do before we can merge this?

@natecook1000 natecook1000 merged commit 14cba5d into apple:main Dec 11, 2023
@natecook1000
Copy link
Member

Nope! Thanks @compnerd!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants