Swift 6 preparedness #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation
We should feel confident that we compile clean under the strict
checks of Swift 6. As this is a data-processing-only framework
it's not a surprise that it turns out to be fine, but this patch
adds the necessary docker-compose steps to ensure it continues
to work.
Modifications
- Add docker-compose file for Swift 6 nightlies
- Extend docker-compose to pass explicit sendable and strict
concurrency checks
- Add those checks to 6.0 and main nightlies
Result
Better confidence that we don't break our downstreams in Swift 6
support.
PeterAdams-A
approved these changes
May 30, 2024
glbrntt
approved these changes
May 30, 2024
gjcairo
approved these changes
May 30, 2024
|
@swift-server-bot test this please |
dnadoba
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We should feel confident that we compile clean under the strict checks of Swift 6. As this is a data-processing-only framework it's not a surprise that it turns out to be fine, but this patch adds the necessary docker-compose steps to ensure it continues to work.
Modifications
Result
Better confidence that we don't break our downstreams in Swift 6 support.