Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generalized ActorID metadata encoding/decoding #987

Open
ktoso opened this issue Jul 6, 2022 · 2 comments
Open

Generalized ActorID metadata encoding/decoding #987

ktoso opened this issue Jul 6, 2022 · 2 comments
Assignees
@ktoso
Labels
3 - in progress Ticket is being worked on t:serialization
Milestone
1.0.0-beta.4

Comments

@ktoso
Copy link
Member

ktoso commented Jul 6, 2022

We allow storing metadata with @ActorID.Metadata but the serialization is only partially implemented, support it completely by allowing to register which keys should be considered.
@ktoso
Copy link
Member Author

ktoso commented Jul 6, 2022

// FIXME: implement decoding tags/metadata in general in Sources/DistributedActors/ActorID.swift

@ktoso ktoso modified the milestones: 1.0.0-beta.x, 1.0.0-beta.2 Jul 6, 2022
@ktoso ktoso added 1 - triaged Ticket makes sense and is well defined, ready to be worked on 2 - pick next If looking for work, pick this ticket :-) t:serialization labels Jul 11, 2022
@ktoso
Copy link
Member Author

ktoso commented Jul 11, 2022

We need this earlier rather than later

@ktoso ktoso self-assigned this Jul 13, 2022
@ktoso ktoso added 3 - in progress Ticket is being worked on and removed 1 - triaged Ticket makes sense and is well defined, ready to be worked on 2 - pick next If looking for work, pick this ticket :-) labels Jul 13, 2022
ktoso added a commit to ktoso/swift-distributed-actors that referenced this issue Jul 13, 2022
@ktoso
=ser serializing actor id metadata, incl. wellKnown apple#987
3426c62
ktoso added a commit to ktoso/swift-distributed-actors that referenced this issue Jul 15, 2022
@ktoso
=ser serializing actor id metadata, incl. wellKnown apple#987
48bdb59
yim-lee pushed a commit to yim-lee/swift-distributed-actors that referenced this issue Jul 15, 2022
@ktoso @yim-lee
=ser serializing actor id metadata, incl. wellKnown apple#987
a02217a
ktoso added a commit to ktoso/swift-distributed-actors that referenced this issue Jul 20, 2022
@ktoso
=ser serializing actor id metadata, incl. wellKnown apple#987
11b248a
ktoso added a commit that referenced this issue Jul 20, 2022
@ktoso @yim-lee
Distributed Actor support in Cluster Singleton (#1010)
ad8e6b6 
* Implement ActorSingleton for DistributedActor

Resolves #824

* rework how we get hold of intercepted actors

* rework how we get hold of intercepted actors

* fix eventually{} to work with async code; remove thread local use

* progress-ktoso

* singleton call through remoteCall causes localCall

* more logic in resolving a well-known actor

* =ser serializing actor id metadata, incl. wellKnown #987

* wip

* fix serialization of well known metadata

* fix equality

* passing happy path test

* Rebase and resolve conflicts

* Update the rest of singleton tests

* fix WorkerPool APIs a bit

* cleanups

* [Receptionist] Fix ordering bug and improve diagnostics

* fix wellKnown name handling from props

* cleanup

* rebase fix

* handle swift-metrics internal field rename

Co-authored-by: Yim Lee <[email protected]>
@ktoso ktoso modified the milestones: 1.0.0-beta.2, 1.0.0-beta.3 Jul 28, 2022
@ktoso ktoso modified the milestones: 1.0.0-beta.3, 1.0.0-beta.4 Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ktoso ktoso

Labels
3 - in progress Ticket is being worked on t:serialization
Projects
None yet
Milestone
1.0.0-beta.4
Development

No branches or pull requests
1 participant
@ktoso