add the NFS3 protocol #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabianfett
reviewed
Apr 22, 2022
weissi
force-pushed
the
jw-nfs3
branch
3 times, most recently
from
e8c99a1 to
ab005f1
Compare
fabianfett
reviewed
Dec 16, 2022
glbrntt
reviewed
Dec 19, 2022
There was a problem hiding this comment.
I left a bunch of comments inline. I have no doubt that I missed things too.
A few general notes:
- There are a bunch of message types which are only
Equatable-- these should probably beHashableandSendabletoo. - The
ByteBufferread helpers don't follow the normal pattern of returningnilif there aren't enough bytes and the write helpers don't return the number of bytes written. - The Mount* types seem to be duplicated as NFS* types. The latter don't appear to be used?
Lukasa
requested changes
Jan 3, 2023
| @@ -108,7 +108,20 @@ var targets: [PackageDescription.Target] = [ | |||
| "NIOSOCKS", | |||
| .product(name: "NIOCore", package: "swift-nio"), | |||
| .product(name: "NIOEmbedded", package: "swift-nio"), | |||
| ]) | |||
| ]), | |||
| .target( | |||
There was a problem hiding this comment.
Are we intentionally not defining a product here?
There was a problem hiding this comment.
@Lukasa for now, yes. In a follow-up I might either add a product (either NIONFS3 or _NIONFS3Preview) but we can discuss then. I want to first land the bulk of the code
Lukasa
approved these changes
Mar 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
NFS can be a very useful protocol.
Modifications:
Add the (read side, for now) of the NFS3 protocol.
This adds (partial) implementations of the following RFCs:
Essentially, NFS3 is a protocol which sends metadata & does framing via the (SUN) RPC protocol. The data is encoded using XDR. If you're familiar with gRPC, then XDR is NFS's protobuf, HTTP is NFS's RPC and NFS3 is the application protocol.
Result:
Left to do before merging:
_NIONFS3Preview?https://github.com/apple/swift-distributed-tracing-baggage.gitis acceptable