Remove indirection between channel and multiplexer #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weissi
requested changes
May 17, 2019
Lukasa
force-pushed
the
cb-avoid-channel-indirection
branch
from
464cf52 to
aa14db6
Compare
Motivation: Previously the HTTP2StreamChannel forwarded all frames to the parent Channel by way of the abstract Channel existential API. While this was straightforward, it added unnecessary overhead due to the extra pipeline steps and the extra indirection of the types providing an inlining barrier. Given that in apple#116 we gave the HTTP2StreamChannel a reference to its parent multiplexer, we may as well take advantage of this and allow direct calls from the stream channel into the multiplexer. Modifications: Avoided calls to parent.write and parent.flush. Replaced them with a new interface. Added new allocation test for this path. Result: Slightly better performance.
Lukasa
force-pushed
the
cb-avoid-channel-indirection
branch
from
aa14db6 to
9bedd22
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Previously the HTTP2StreamChannel forwarded all frames to the parent
Channel by way of the abstract Channel existential API. While this was
straightforward, it added unnecessary overhead due to the extra pipeline
steps and the extra indirection of the types providing an inlining
barrier.
Given that in #116 we gave the HTTP2StreamChannel a reference to its
parent multiplexer, we may as well take advantage of this and allow
direct calls from the stream channel into the multiplexer.
Modifications:
Avoided calls to parent.write and parent.flush.
Replaced them with a new interface.
Result:
Slightly better performance.