Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve docker test setup #129

Merged
merged 1 commit into from
May 21, 2019
Merged

Conversation

tomerd
Copy link
Member

@tomerd tomerd commented May 21, 2019

motivation: test task to include h2spec

changes:

  • remove older docker-compose files that are not in use on the master branch
  • move the task definition from the 18.04/5.0 docker compose file to the generic one
  • create a unit-test task to encapsulate the unit tests and change the test task to include unit tests, integration tests and h2 spec verification

motivation: test task to include h2spec

changes:
* remove older docker-compose files that are not in use on the master branch
* move the task definition from the 18.04/5.0 docker compose file to the generic one
* create a unit-test task to encapsulate the unit tests and change the test task to include unit tests, integration tests and h2 spec verification
@tomerd tomerd requested a review from Lukasa May 21, 2019 02:02
@Lukasa Lukasa added the 🔨 semver/patch No public API change. label May 21, 2019
@Lukasa Lukasa added this to the 1.2.1 milestone May 21, 2019
Copy link
Contributor

@Lukasa Lukasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, adding @weissi as a reviewer as well.

@Lukasa Lukasa requested a review from weissi May 21, 2019 07:44
Copy link
Member

@weissi weissi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@weissi weissi merged commit e25490e into apple:master May 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 semver/patch No public API change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants