Trailers sent on idle streams deserve to be sent too. #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: this issue blocks grpc/grpc-swift#281. |
normanmaurer
requested changes
Nov 16, 2018
| let serverStreamID = try self.assertFramesRoundTrip(frames: [reqFrame, reqBodyFrame], sender: self.clientChannel, receiver: self.serverChannel).first!.streamID | ||
|
|
||
| // Now we can send the next trailers. | ||
| try self.assertFramesRoundTrip(frames: [trailerFrame], sender: self.clientChannel, receiver: self.serverChannel) |
weissi
approved these changes
Nov 16, 2018
There was a problem hiding this comment.
I'm happy but I agree with @normanmaurer that we should sprinkle some XCTAssertNoThrows everywhere :)
|
I can confirm that this fixes the issue I had been encountering. Thank you so much, Corey! |
Motivation: Due to nghttp2's weird data provider model, all trailers go through a similar send path as data frames. This includes the fact that the data sender can go "idle". If the data sender is idle, and the user sends trailers, we don't bother to tell nghttp2 to ask us for more data, so the trailers sit there forever, feeling sad. Modifications: - Correctly restart the data provider when sending data. Result: Trailers will be emitted when the stream is idle.
|
I've updated to use |
|
Thanks, still happy 👌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Due to nghttp2's weird data provider model, all trailers go through a
similar send path as data frames. This includes the fact that the data
sender can go "idle". If the data sender is idle, and the user sends
trailers, we don't bother to tell nghttp2 to ask us for more data,
so the trailers sit there forever, feeling sad.
Modifications:
Result:
Trailers will be emitted when the stream is idle.
Resolves #24.