HTTP/2 pipeline NIOAsyncChannel pipeline config #403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: This continues the work to expose functionality which allows users to interact with HTTP/2 connections via async abstractions and using structured concurrency. We build atop of previous work to configure pipelines to deal with HTTP/2 (with no protocol negotiation) and to wrap connection/stream channels with `NIOAsyncChannel`s. This will allow users to iterate over streams and HTTP2Frames. Modifications: Provide functions which configure channels and pipelines with the HTTP2 handler, expose a multiplexer for dealing with streams and wrap connection and stream channels with `NIOAsyncChannel`s. Result: Users will be able to create and interact with HTTP/2 connections via `NIOAsyncChannel`s. Because HTTP/2 is a negotiated protocol and we do not yet handle it, this is of limited utility.
rnro
force-pushed
the
async_channels_nio_async_channel
branch
from
d46839c to
a186116
Compare
glbrntt
reviewed
Jul 3, 2023
Sources/NIOHTTP2/HTTP2ChannelHandler+InlineStreamMultiplexer.swift
Outdated
Show resolved
Hide resolved
Sources/NIOHTTP2/HTTP2ChannelHandler+InlineStreamMultiplexer.swift
Outdated
Show resolved
Hide resolved
Sources/NIOHTTP2/HTTP2ChannelHandler+InlineStreamMultiplexer.swift
Outdated
Show resolved
Hide resolved
Sources/NIOHTTP2/HTTP2ChannelHandler+InlineStreamMultiplexer.swift
Outdated
Show resolved
Hide resolved
Tests/NIOHTTP2Tests/ConfiguringPipelineAsyncMultiplexerTests.swift
Outdated
Show resolved
Hide resolved
Tests/NIOHTTP2Tests/ConfiguringPipelineAsyncMultiplexerTests.swift
Outdated
Show resolved
Hide resolved
Tests/NIOHTTP2Tests/ConfiguringPipelineAsyncMultiplexerTests.swift
Outdated
Show resolved
Hide resolved
rnro
force-pushed
the
async_channels_nio_async_channel
branch
from
2ab9b08 to
664601a
Compare
glbrntt
reviewed
Jul 3, 2023
Sources/NIOHTTP2/HTTP2ChannelHandler+InlineStreamMultiplexer.swift
Outdated
Show resolved
Hide resolved
…wift Co-authored-by: George Barnett <[email protected]>
glbrntt
approved these changes
Jul 3, 2023
FranzBusch
reviewed
Jul 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
This continues the work to expose functionality which allows users to interact with HTTP/2 connections via async abstractions and using structured concurrency.
We build atop of previous work to configure pipelines to deal with HTTP/2 (with no protocol negotiation) and to wrap connection/stream channels with
NIOAsyncChannels. This will allow users to iterate over streams and HTTP2Frames.Modifications:
Provide functions which configure channels and pipelines with the HTTP2 handler, expose a multiplexer for dealing with streams and wrap connection and stream channels with
NIOAsyncChannels.Result:
Users will be able to create and interact with HTTP/2 connections via
NIOAsyncChannels. Because HTTP/2 is a negotiated protocol and we do not yet handle it, this is of limited utility.