Make HEADERS frame payload non-indirect #428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lukasa
force-pushed
the
cb-non-indirect-headers
branch
from
b438da2 to
34390e5
Compare
|
Can we add a unit test that checks that the size of |
Lukasa
force-pushed
the
cb-non-indirect-headers
branch
from
34390e5 to
002ec5e
Compare
|
Done. |
dnadoba
approved these changes
Nov 16, 2023
glbrntt
approved these changes
Nov 16, 2023
Sources/NIOHTTP2/HTTP2Frame.swift
Outdated
Comment on lines
34
to
38
| internal init(exclusive: Bool, dependency: HTTP2StreamID, weight: UInt8) { | ||
| self.exclusive = exclusive | ||
| self.dependency = dependency | ||
| self.weight = weight | ||
| } |
There was a problem hiding this comment.
Was the init intentionally internal before?
It's a parameter in Headers.init but is defaulted to nil so it looks like it not being public was an oversight?
There was a problem hiding this comment.
Seems like an oversight to me as well
|
The CI failure is interesting:
|
Motivation:
In previous patches we shrank the size of HTTP2Frame by
making various data types indirect in the frame payload.
This included HEADERS, which is unfortunte as HEADERS frames
are quite common.
This patch changes the layout of the HEADERS frame to remove the
indirect case.
Modifications:
- Move END_STREAM into an OptionSet.
- Turn the two optional bits into flags in the aforementioned
OptionSet
- Replace the properties with computed properties.
- Remove the indirect case
Result:
HEADERS frames are cheaper.
Lukasa
force-pushed
the
cb-non-indirect-headers
branch
from
002ec5e to
b42fbe5
Compare
Lukasa
added
🆕 semver/minor
|
Updated. |
|
Now we are hitting depreciation warnings because of the new NIO release: |
|
I have reported the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
In previous patches we shrank the size of HTTP2Frame by making various data types indirect in the frame payload. This included HEADERS, which is unfortunte as HEADERS frames are quite common.
This patch changes the layout of the HEADERS frame to remove the indirect case.
Modifications:
Result:
HEADERS frames are cheaper.