Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove precondition: yielding to terminated AsyncSequence #432

Merged
merged 3 commits into from
Dec 20, 2023
Merged

Remove precondition: yielding to terminated AsyncSequence #432

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fdc7b4c
Remove precondition: yielding to terminated AsyncSequence
rnro Dec 20, 2023
7dabfb4
add test
rnro Dec 20, 2023
3836c4c
Merge branch 'main' into HTTP_2_stream_async_stream_crashes_on_cancel…
Lukasa Dec 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions Sources/NIOHTTP2/HTTP2CommonInboundStreamMultiplexer.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -489,10 +489,12 @@ extension NIOHTTP2AsyncSequence {
switch yieldResult {
case .enqueued:
break // success, nothing to do
case .terminated:
// this can happen if the task has been cancelled
// we can't do better than dropping the message at the moment
break
case .dropped:
preconditionFailure("Attempted to yield when AsyncThrowingStream is over capacity. This shouldn't be possible for an unbounded stream.")
case .terminated:
preconditionFailure("Attempted to yield to AsyncThrowingStream in terminated state.")
default:
preconditionFailure("Attempt to yield to AsyncThrowingStream failed for unhandled reason.")
}
Expand Down