fix Bench1Conn10kRequests crash #434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glbrntt
approved these changes
Jan 8, 2024
Motivation: `Bench1Conn10kRequests` performance tester incorrectly used a `NIOLoopBound` to access the `HTTP2StreamMultiplexer` to create streams. Modifications: Access the multiplexer by safely obtaining a reference to the handler. Result: - `Bench1Conn10kRequests` are not broken Co-authored-by: George Barnett <[email protected]>
rnro
force-pushed
the
Bench1Conn10kRequests_sendability
branch
from
932bec1 to
102df9e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Bench1Conn10kRequestsperformance tester incorrectly used aNIOLoopBoundto access theHTTP2StreamMultiplexerto create streams.Modifications:
Access the multiplexer by safely obtaining a reference to the handler.
Result:
Bench1Conn10kRequestsare not broken