Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support request and response body streaming in the URLSession transport #301

Closed
czechboy0 opened this issue Sep 27, 2023 · 1 comment
Closed

Support request and response body streaming in the URLSession transport #301

czechboy0 opened this issue Sep 27, 2023 · 1 comment
Assignees
@simonjbeaumont
Labels
area/transport Affects: Client or server transport library. kind/enhancement Improvements to existing feature.
Milestone
1.0

Comments

@czechboy0
Copy link
Contributor

Support request and response body streaming in the URLSession transport.

We originally landed 0.3.0 of the URLSession transport with internal buffering. This issue tracks improving the internals and avoid the buffering. Can be done in an API-stable way, so wasn't a blocker of 0.3.0.
@czechboy0 czechboy0 added area/transport Affects: Client or server transport library. kind/enhancement Improvements to existing feature. labels Sep 27, 2023
@czechboy0 czechboy0 added this to the 1.0 milestone Sep 27, 2023
@czechboy0 czechboy0 mentioned this issue Sep 27, 2023
Merged
czechboy0 added a commit to apple/swift-openapi-urlsession that referenced this issue Oct 2, 2023
@czechboy0
[URLSession Transport] Async bodies + swift-http-types adoption (#15)
2a676df 
[URLSession Transport] Async bodies + swift-http-types adoption

### Motivation

URLSession transport changes of the approved proposals apple/swift-openapi-generator#255 and apple/swift-openapi-generator#254.

### Modifications

- Adapts to the runtime changes, depends on HTTPTypes now.
- Doesn't do streaming yet, we'll addressed that separately, continues to buffer for now (apple/swift-openapi-generator#301)

### Result

Transport works with the 0.3.0 runtime API of.

### Test Plan

Adapted tests.


Reviewed by: simonjbeaumont

Builds:
     ✔︎ pull request validation (5.8) - Build finished. 
     ✔︎ pull request validation (5.9) - Build finished. 
     ✔︎ pull request validation (nightly) - Build finished. 
     ✔︎ pull request validation (soundness) - Build finished. 

#15
@czechboy0
Copy link
Contributor Author

Landed in apple/swift-openapi-urlsession#24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simonjbeaumont simonjbeaumont

Labels
area/transport Affects: Client or server transport library. kind/enhancement Improvements to existing feature.
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
2 participants
@simonjbeaumont @czechboy0