Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swift 6 prep - Part 1 #106

Merged
merged 2 commits into from
Jun 11, 2024
Merged

Swift 6 prep - Part 1 #106

merged 2 commits into from
Jun 11, 2024

Conversation

czechboy0
Copy link
Contributor

Motivation

Fixes to get closer to building in Swift 6 mode without diagnostics.

Modifications

  • Made two public types Sendable
  • s/#file/#filePath in tests

Result

Builds with fewer warnings when trying Swift 6 mode (will open another PR for the remaining work).

Test Plan

Unit tests passed.

@czechboy0 czechboy0 requested a review from simonjbeaumont June 11, 2024 12:57
@czechboy0 czechboy0 enabled auto-merge (squash) June 11, 2024 14:44
@czechboy0 czechboy0 merged commit acb1838 into apple:main Jun 11, 2024
8 checks passed
@czechboy0 czechboy0 deleted the hd-swift-6-prep branch June 11, 2024 15:33
@czechboy0 czechboy0 added the 🔨 semver/patch No public API change. label Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FranzBusch FranzBusch FranzBusch approved these changes

@simonjbeaumont simonjbeaumont simonjbeaumont approved these changes

Assignees
No one assigned
Labels
🔨 semver/patch No public API change.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@czechboy0 @simonjbeaumont @FranzBusch