Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Multipart] Add the frame -> bytes serializer #73

Merged
merged 3 commits into from
Nov 16, 2023

Conversation

czechboy0
Copy link
Contributor

Motivation

Second state machine, doing the inverse of #72, serializes frames into bytes.

Modifications

  • A new state machine.
  • A new serializer wrapping the state machine.
  • An async sequence wrapping the serializer.

Result

We can now serialize multipart frames into bytes.

Test Plan

Unit tests for all 3 layers.

Copy link
Collaborator

@simonjbeaumont simonjbeaumont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Minor comment.

@czechboy0 czechboy0 merged commit 94c1b30 into apple:main Nov 16, 2023
@czechboy0 czechboy0 deleted the hd-multipart-serializer branch November 16, 2023 16:43
@czechboy0 czechboy0 added the 🔨 semver/patch No public API change. label Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 semver/patch No public API change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants