[Multipart] Add public types #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czechboy0
commented
Nov 20, 2023
simonjbeaumont
requested changes
Nov 24, 2023
Sources/OpenAPIRuntime/Multipart/MultipartBoundaryGenerator.swift
Outdated
Show resolved
Hide resolved
Tests/OpenAPIRuntimeTests/Multipart/Test_MultipartBoundaryGenerator.swift
Outdated
Show resolved
Hide resolved
Co-authored-by: Si Beaumont <[email protected]>
…rator.swift Co-authored-by: Si Beaumont <[email protected]>
simonjbeaumont
approved these changes
Nov 24, 2023
|
LGTM, feel free to land once you appease the CI (probably my bad suggestions causing formatting complaints; didn't check). I guess you'll need to merge over the API checker, which you said is a false positive. |
czechboy0
added
🔨 semver/patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Add the public types approved in SOAR-0009.
Modifications
Added the public types and make other changes outlined in SOAR-0009.
Result
Most of the required runtime types are now in place.
Test Plan
Added unit tests for the new code, where it made sense.
pull request validation (api breakage)is failing with:but that seems to be a false positive in the tool, as there is now a newer initializer that you can use as
.init(),.init(dateTranscoder:),.init(multipartBoundaryGenerator:), orinit(dateTranscoder:multipartBoundaryGenerator:), so no existing code could be broken by this change.