-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use idiomatic location for security directory and update location of configuration directory #3942
Conversation
72c774c
to
b639354
Compare
b639354
to
15ea6e7
Compare
We're talking about |
…configuration directory motivation: use idiomatic location for security directory on macOS changes: * allow users to customize security directory location with new --security-path CLI option * on macOS use <user>/Library/org.swiftpm/security for security files and symlink from ~/.swiftpm/security * move configuration directory from <user>/Library/org.swiftpm to <user>/Library/org.swiftpm/configuration * add migration code from old configuraiton location to new one * add and adjust tests * update docker setup for new locationis
15ea6e7
to
08f96cb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's make sure source compat test passes before merging?
We can use: swiftlang/swift#40524
@swift-ci please smoke test |
@yim-lee revised per discussion + addressed other comments |
@neonichu @abertelrud we have been using note the migration code does not delete / move the old files, it copies them from on non-Darwin platform this moves the configuration files from one nice thing with this is that it also matched the changes we made earlier this year moving the "local" (package root) wdyt? |
@swift-ci please smoke test |
that test passed, so we should be good |
We have to make sure that users understand that there are two different config files, right now we're only warning one time on copy, correct? I think we need to warn on load as long as both locations exist. |
|
2b238b7
to
2ba88d3
Compare
@swift-ci please smoke test |
…configuration directory (swiftlang#3942) motivation: use idiomatic location for security directory on macOS changes: * allow users to customize security directory location with new --security-path CLI option * on macOS use <user>/Library/org.swiftpm/security for security files and symlink from ~/.swiftpm/security * move configuration directory from <user>/Library/org.swiftpm to <user>/Library/org.swiftpm/configuration * add migration code from old configuraiton location to new one * add and adjust tests * update docker setup for new locationis
…configuration directory (#3942) motivation: use idiomatic location for security directory on macOS changes: * allow users to customize security directory location with new --security-path CLI option * on macOS use <user>/Library/org.swiftpm/security for security files and symlink from ~/.swiftpm/security * move configuration directory from <user>/Library/org.swiftpm to <user>/Library/org.swiftpm/configuration * add migration code from old configuraiton location to new one * add and adjust tests * update docker setup for new locationis
motivation: use idiomatic location for security directory on macOS
changes: