refactor workspace initializers #3933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomerd
force-pushed
the
refactor/workspace-setup
branch
2 times, most recently
from
c38affc to
d2ba4e0
Compare
tomerd
commented
Dec 11, 2021
tomerd
force-pushed
the
refactor/workspace-setup
branch
from
d2ba4e0 to
5ca7853
Compare
tomerd
force-pushed
the
refactor/workspace-setup
branch
2 times, most recently
from
049f27b to
2e5864a
Compare
yim-lee
reviewed
Dec 14, 2021
tomerd
force-pushed
the
refactor/workspace-setup
branch
3 times, most recently
from
bd2376a to
fb715fc
Compare
|
extracted the configuration + security location changes into #3942 |
tomerd
force-pushed
the
refactor/workspace-setup
branch
2 times, most recently
from
6a03cd9 to
64476bd
Compare
tomerd
commented
Dec 15, 2021
tomerd
force-pushed
the
refactor/workspace-setup
branch
from
64476bd to
7fb7628
Compare
tomerd
commented
Dec 16, 2021
tomerd
force-pushed
the
refactor/workspace-setup
branch
2 times, most recently
from
c3ce0ab to
8489d7e
Compare
abertelrud
approved these changes
Dec 16, 2021
tomerd
force-pushed
the
refactor/workspace-setup
branch
5 times, most recently
from
21e859c to
c5bcf54
Compare
tomerd
force-pushed
the
refactor/workspace-setup
branch
3 times, most recently
from
edc31b7 to
6688990
Compare
|
@swift-ci please smoke test |
tomerd
changed the title
tomerd
changed the title
tomerd
force-pushed
the
refactor/workspace-setup
branch
2 times, most recently
from
c77247c to
4757018
Compare
|
@swift-ci please smoke test |
tomerd
force-pushed
the
refactor/workspace-setup
branch
from
4757018 to
b8b9b74
Compare
tomerd
added
ready
tomerd
changed the title
|
@swift-ci please smoke test |
1 similar comment
|
@swift-ci please smoke test |
motivation: workspace initializer is very robust, accomodating the needs of both libSwiftPM consumer and testing. we want to seperate these concerns a bit so that libSwiftPM exposes the minimum API surface area changes: * deprecate existing workspace inisitlazer * create new minimalistic public initializer oriented towards libSwiftPM consumers * create internal initializer with all custmization options oriented towards testing * better abstract resolver configuraiton and other behavior settings into a struct * pass observability scope to workspace initializer via thread local (from CLI) * update callsite and tests to the new API
tomerd
force-pushed
the
refactor/workspace-setup
branch
from
615db52 to
6f52ce9
Compare
|
@swift-ci please smoke test |
tomerd
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
motivation: workspace initializer is very robust, accomodating the needs of both libSwiftPM consumer and testing. we want to seperate these concerns a bit so that libSwiftPM exposes the minimum API surface area
changes: