Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider moving up to Swift 5.0 as the minimum compiler and language versions #1210

Closed
thomasvl opened this issue Feb 8, 2022 · 2 comments
Closed

Comments

@thomasvl
Copy link
Collaborator

thomasvl commented Feb 8, 2022

We currently require a 4.2 or later compiler and support the language version of 4.2 or later.

According to https://www.swift.org/download/, 4.2 came out with Xcode 10.0 on September 17, 2018; 4.2.1 was Xcode 10.1 on October 30, 2018. 4.2.2 & 4.2.3 were linux only, with the later being on February 28, 2019. 4.2.4 was on March 29, 2019 and is Ubuntu 16.04 only.

There is specific support for 4.2 in the library and generator, so it would simply things. The AppStore won't accept things off that older Xcode version, but in theory , someone could be using a newer compiler but still compiling the generated code in the 4.2 mode.

Swift Package Index compatibility reports these days only mention the 5.x version, so that might be a signal that the 4.x support really can be dropped.

Thoughts?

@thomasvl thomasvl changed the title Consider moving up to Swift 5.0 as the minimum Swift version Consider moving up to Swift 5.0 as the minimum compiler and language versions Feb 8, 2022
@thomasvl
Copy link
Collaborator Author

thomasvl commented Mar 7, 2022

We should also revisit https://github.com/apple/swift-protobuf/labels/API%20change for things to do as part of a major version bump.

thomasvl added a commit to thomasvl/swift-protobuf that referenced this issue Apr 7, 2022
thomasvl added a commit to thomasvl/swift-protobuf that referenced this issue Apr 7, 2022
thomasvl added a commit to thomasvl/swift-protobuf that referenced this issue Apr 7, 2022
thomasvl added a commit to thomasvl/swift-protobuf that referenced this issue Apr 7, 2022
thomasvl added a commit to thomasvl/swift-protobuf that referenced this issue Apr 7, 2022
Update generation to also add allCases (when needed) in that main decl for the
enum.

Progress on apple#1210
thomasvl added a commit that referenced this issue Apr 7, 2022
thomasvl added a commit that referenced this issue Apr 7, 2022
Update generation to also add allCases (when needed) in that main decl for the
enum.

Progress on #1210
thomasvl added a commit that referenced this issue Apr 7, 2022
thomasvl added a commit that referenced this issue Apr 7, 2022
thomasvl added a commit to thomasvl/swift-protobuf that referenced this issue Apr 7, 2022
thomasvl added a commit that referenced this issue Apr 7, 2022
@thomasvl
Copy link
Collaborator Author

thomasvl commented Apr 7, 2022

Calling this fixed/done as the only conditionals left in the library and generated code are now around the 5.5 needs for Sendable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant