Move the two extension range helpers out of Descriptor. #1298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These two apis aren't a normal part of the C++ Descriptor api, so move them out to the plugin level itself so they aren't public api going forward. As of http://github.com/apple/swift-package-manager/pull/3316 tests can depend on executable targets. The majority of this CL is then adding a new test (only for newer SwiftPM versions) that allows the tests also to have been moved over.
tbkka
approved these changes
Sep 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These two apis aren't a normal part of the C++ Descriptor api, so move them out to the plugin level itself so they aren't public api going forward.
As of http://github.com/apple/swift-package-manager/pull/3316 tests can depend on executable targets. The majority of this CL is then adding a new test (only for newer SwiftPM versions) that allows the tests also to have been moved over.