1.x branch Better Plugin Support #1485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the concept of a `CodeGenerator` and some building blocks to go with it so some of the boilerplate around writing plugins is provided. This is the start of the building blocks to make supporting Editions easier for any plugin (grpc) when that support lands as it will make a lot of the setup details hidden rather than having to be implemented by each plugin.
Before it would silently ignore the attempt, which might confuse users.
|
The build failures on upstream protobuf are known and I think they are working to resolve. |
Extend `CodeGenerator` to allow easy customization and generally provide what's needed for a `main()` so plugins don't have to reimplement everything.
If there are a lot files generated, this linear check could have become an issue.
thomasvl
force-pushed
the
1_x_better_plugin_support
branch
from
589f501 to
ef34a25
Compare
allevato
approved these changes
Oct 26, 2023
|
The 5.0.3 and 4.2.4 breaks confuse me, I didn't even change those files. I wonder is something just happened to the swift docker images? |
Oh, those are just notes, they must always be there. But I am using another api that I guess is an issue. |
Looks like `#available` isn't enough for some api usage in the really old Swift versions, so add a fallback for that case also.
thomasvl
force-pushed
the
1_x_better_plugin_support
branch
from
bd80516 to
32183da
Compare
|
CI passes now with the fix for FileHandle on Swift <5.1 (and upstream protobuf having been fixed) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is #1483, but for the 1.x release branch
There are two minor changes:
@mainserializeBytesvs.serializedData.