Remove 'u' suffix support from TextFormat. #1642
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://protobuf.dev/reference/protobuf/textformat-spec/#numeric and https://protobuf.dev/reference/protobuf/textformat-spec/#literals don't seem to show any signs that a 'u' suffix was ever valid. I also don't see any references in the C++ code. It also seems like we would parse
-12u
as valid which seems a little odd since it clearly isn't an unsigned value.So dropping the 'u' support as it seems out of spec.