Add a initializer to Google_Protobuf_Duration with rounding control. #1747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provide a new initializer with explicit rounding controls and map the other initializer though the single code paths.
|
There's a question to if we should deprecate the existing apis in favor of this this new one. Thoughts? |
|
IMO, I would deprecate |
Also remove the tests so we can still build/test warnings free and with warnings upgraded to errors.
Pushed a second commit with that, I can also drop it and force push again if we don't want to do it. |
allevato
approved these changes
Jan 16, 2025
tbkka
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide a new initializer with explicit rounding controls and map the other initializer though the single code paths.