feat: add async feedback hook option #414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
golangcibot
reviewed
Jun 3, 2019
golangcibot
reviewed
Jun 3, 2019
appleboy
requested changes
Jun 23, 2019
| req.Header.Set("Content-Type", "application/json; charset=utf-8") | ||
|
|
||
| HTTPClient := &http.Client{} | ||
| resp, err := HTTPClient.Do(req) |
There was a problem hiding this comment.
check resp state
if resp != nil {
defer resp.Body.Close()
}There was a problem hiding this comment.
thx for the feedback. Done in cbb5997
Codecov Report
@@ Coverage Diff @@
## master #414 +/- ##
=========================================
- Coverage 84.15% 84.1% -0.05%
=========================================
Files 18 19 +1
Lines 1325 1346 +21
=========================================
+ Hits 1115 1132 +17
- Misses 170 172 +2
- Partials 40 42 +2
Continue to review full report at Codecov.
|
golangcibot
reviewed
Jul 5, 2019
|
@appleboy do you have any other feedbacks? |
appleboy
approved these changes
Sep 6, 2019
|
@yacir Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for async logs #386