fix incorrect pin count when filtering #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lidel
suggested changes
Mar 17, 2022
There was a problem hiding this comment.
Let's ensure a real array is always present. iiuc this should avoid triggering panic (ipfs/go-pinning-service-http-client#14):
gmelodie
force-pushed
the
fix-invalid-pin-count
branch
from
c27af2b to
2c2b01e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When querying for
/pinning/pins?status=SOMESTATUSthe API was actually listing the count of the original query (before applying the status filter). So for instance if you had 15 pins total but only 2 of them were queued and you requested/pinning/pins?status=queuedyou would get acountof 15 instead of 2.Fixes #124