-
Notifications
You must be signed in to change notification settings - Fork 117
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix gem proxy config on Ruby <3.2 with psych 5
We got several reports in issue #904 that installing the AppSignal gem on system with Ruby < 3.2 with also the psych gem version 5 installed won't work and raise an error breaking the app installation. This related PR #913, which is also needed to fix the whole issue. This PR removes the need for YAML parsing during the installation for the extension download information. This change silences the secondary error that is triggered when we fetch the rubygems config, specified in the `.gemrc` file. This also triggers that error from within rubygems. Instead, users can use the `HTTP_PROXY` environment variable to configure the HTTP proxy. This is not an ideal fix. We also don't communicate that this behavior is happening with this fix. I suggest we report a bug report upstream as detailed in #904, so we can remove this rescue-statement.
- Loading branch information
Showing
2 changed files
with
28 additions
and
7 deletions.
There are no files selected for viewing
6 changes: 6 additions & 0 deletions
6
...sets/skip--gemrc-config-during-installation-if-it-raises-an-error-loading-it.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
--- | ||
bump: "patch" | ||
type: "fix" | ||
--- | ||
|
||
Skip the `.gemrc` config during installation if it raises an error loading it. This can be caused when the psych gem version 5 is installed on Ruby < 3.2. Use the `HTTP_PROXY` environment variable instead to configure the HTTP proxy that should be used during installation. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters