Fix gem proxy config on Ruby <3.2 with psych 5 #914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We got several reports in issue #904 that installing the AppSignal gem on system with Ruby < 3.2 with also the psych gem version 5 installed won't work and raise an error breaking the app installation. This related PR #913, which is also needed to fix the whole issue. This PR removes the need for YAML parsing during the installation for the extension download information. This change silences the secondary error that is triggered when we fetch the rubygems config, specified in the `.gemrc` file. This also triggers that error from within rubygems. Instead, users can use the `HTTP_PROXY` environment variable to configure the HTTP proxy. This is not an ideal fix. We also don't communicate that this behavior is happening with this fix. I suggest we report a bug report upstream as detailed in #904, so we can remove this rescue-statement.
luismiramirez
approved these changes
Jan 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We got several reports in issue #904 that installing the AppSignal gem on system with Ruby < 3.2 with also the psych gem version 5 installed won't work and raise an error breaking the app installation.
This related PR #913, which is also needed to fix the whole issue. This PR removes the need for YAML parsing during the installation for the extension download information.
This change silences the secondary error that is triggered when we fetch the rubygems config, specified in the
.gemrcfile. This also triggers that error from within rubygems. Instead, users can use theHTTP_PROXYenvironment variable to configure the HTTP proxy.This is not an ideal fix. We also don't communicate that this behavior is happening with this fix. I suggest we report a bug report upstream as detailed in #904, so we can remove this rescue-statement.