fix: Remove Excel download option from Table widget (#38996)

appsmithorg · Feb 4, 2025 · 1de2408 · 1de2408
1 parent 3bbdcbc
commit 1de2408
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 16 deletions.
diff --git a/app/client/cypress/e2e/Regression/ClientSide/Widgets/TableV2/TableV2Filter2_2_Spec.ts b/app/client/cypress/e2e/Regression/ClientSide/Widgets/TableV2/TableV2Filter2_2_Spec.ts
@@ -36,8 +36,9 @@ describe(
       //cy.verifyDownload("Table1.csv")
       table.ValidateDownloadNVerify("Table1.csv", "Michael Lawson");
 
-      table.DownloadFromTable("Download as Excel");
-      table.ValidateDownloadNVerify("Table1.xlsx", "Michael Lawson");
+      // @rahulbarwal temporarily commenting download as excel feature till we have a proper fix to the issue: https://github.com/appsmithorg/appsmith/issues/38995
+      // table.DownloadFromTable("Download as Excel");
+      // table.ValidateDownloadNVerify("Table1.xlsx", "Michael Lawson");
     });
 
     it("2. Verify Searched data - download csv and download Excel", function () {
@@ -51,16 +52,18 @@ describe(
       //cy.verifyDownload("Table1.csv")
       table.ValidateDownloadNVerify("Table1.csv", "[email protected]");
 
-      table.DownloadFromTable("Download as Excel");
-      table.ValidateDownloadNVerify("Table1.xlsx", "Ryan Holmes");
+      // @rahulbarwal temporarily commenting download as excel feature till we have a proper fix to the issue: https://github.com/appsmithorg/appsmith/issues/38995
+      // table.DownloadFromTable("Download as Excel");
+      // table.ValidateDownloadNVerify("Table1.xlsx", "Ryan Holmes");
 
       table.RemoveSearchTextNVerify("2381224", "v2");
 
       table.DownloadFromTable("Download as CSV");
       table.ValidateDownloadNVerify("Table1.csv", "2736212");
 
-      table.DownloadFromTable("Download as Excel");
-      table.ValidateDownloadNVerify("Table1.xlsx", "Beef steak");
+      // @rahulbarwal temporarily commenting download as excel feature till we have a proper fix to the issue: https://github.com/appsmithorg/appsmith/issues/38995
+      // table.DownloadFromTable("Download as Excel");
+      // table.ValidateDownloadNVerify("Table1.xlsx", "Beef steak");
     });
 
     it("3. Verify Filtered data - download csv and download Excel", function () {
@@ -75,17 +78,19 @@ describe(
       //cy.verifyDownload("Table1.csv")
       table.ValidateDownloadNVerify("Table1.csv", "Beef steak");
 
-      table.DownloadFromTable("Download as Excel");
-      table.ValidateDownloadNVerify("Table1.xlsx", "[email protected]");
+      // @rahulbarwal temporarily commenting download as excel feature till we have a proper fix to the issue: https://github.com/appsmithorg/appsmith/issues/38995
+      // table.DownloadFromTable("Download as Excel");
+      // table.ValidateDownloadNVerify("Table1.xlsx", "[email protected]");
 
       agHelper.GetNClick(table._filterBtn);
       table.RemoveFilterNVerify("2381224", true, false, 0, "v2");
 
       table.DownloadFromTable("Download as CSV");
       table.ValidateDownloadNVerify("Table1.csv", "Tuna Salad");
 
-      table.DownloadFromTable("Download as Excel");
-      table.ValidateDownloadNVerify("Table1.xlsx", "Avocado Panini");
+      // @rahulbarwal temporarily commenting download as excel feature till we have a proper fix to the issue: https://github.com/appsmithorg/appsmith/issues/38995
+      // table.DownloadFromTable("Download as Excel");
+      // table.ValidateDownloadNVerify("Table1.xlsx", "Avocado Panini");
     });
 
     it("4. Import TableFilter application & verify all filters for same FirstName (one word column) + Bug 13334", () => {

diff --git a/app/client/cypress/e2e/Regression/ServerSide/GenerateCRUD/MongoURI_Spec.ts b/app/client/cypress/e2e/Regression/ServerSide/GenerateCRUD/MongoURI_Spec.ts
@@ -206,8 +206,9 @@ describe(
       table.DownloadFromTable("Download as CSV");
       table.ValidateDownloadNVerify("data_table.csv", "USB Stick (Green)");
 
-      table.DownloadFromTable("Download as Excel");
-      table.ValidateDownloadNVerify("data_table.xlsx", "USB Stick (Leaf)");
+      // @rahulbarwal temporarily commenting download as excel feature till we have a proper fix to the issue: https://github.com/appsmithorg/appsmith/issues/38995
+      // table.DownloadFromTable("Download as Excel");
+      // table.ValidateDownloadNVerify("data_table.xlsx", "USB Stick (Leaf)");
       table.OpenFilter();
       table.RemoveFilter();
       agHelper

diff --git a/app/client/src/widgets/TableWidgetV2/component/header/actions/Download.tsx b/app/client/src/widgets/TableWidgetV2/component/header/actions/Download.tsx
@@ -91,10 +91,6 @@ const dowloadOptions: DownloadOptionProps[] = [
     label: "Download as CSV",
     value: "CSV",
   },
-  {
-    label: "Download as Excel",
-    value: "EXCEL",
-  },
 ];
 
 const downloadDataAsCSV = (props: {