update add to map logic

appsmithorg · Jul 1, 2024 · 239a42f · 239a42f
1 parent 3a0653f
commit 239a42f
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 17 deletions.
diff --git a/...th-server/src/main/java/com/appsmith/server/datasources/base/DatasourceServiceCEImpl.java b/...th-server/src/main/java/com/appsmith/server/datasources/base/DatasourceServiceCEImpl.java
@@ -232,16 +232,9 @@ private Mono<Datasource> createEx(
                             .create(datasourceStorage, isDryOps)
                             .map(datasourceStorage1 -> {
                                 if (datasourceStorageDryRunQueries != null && isDryOps) {
-                                    if (datasourceStorageDryRunQueries.containsKey(DBOpsType.SAVE.name())) {
-                                        datasourceStorageDryRunQueries
-                                                .get(DBOpsType.SAVE.name())
-                                                .add(datasourceStorage1);
-                                    } else {
-                                        List<DatasourceStorage> datasourceStorageList = new ArrayList<>();
-                                        datasourceStorageList.add(datasourceStorage1);
-                                        datasourceStorageDryRunQueries.put(
-                                                DBOpsType.SAVE.name(), datasourceStorageList);
-                                    }
+                                    datasourceStorageDryRunQueries
+                                            .computeIfAbsent(DBOpsType.SAVE.name(), k -> new ArrayList<>())
+                                            .add(datasourceStorage1);
                                 }
                                 return datasourceStorage1;
                             });

diff --git a/...in/java/com/appsmith/server/datasources/importable/DatasourceImportableServiceCEImpl.java b/...in/java/com/appsmith/server/datasources/importable/DatasourceImportableServiceCEImpl.java
@@ -409,12 +409,6 @@ public Flux<Datasource> getEntitiesPresentInWorkspace(String workspaceId) {
 
     private void addDryOpsForEntity(
             DBOpsType queryType, Map<String, List<Datasource>> dryRunOpsMap, Datasource createdDatasource) {
-        if (dryRunOpsMap.containsKey(queryType.name())) {
-            dryRunOpsMap.get(queryType.name()).add(createdDatasource);
-        } else {
-            List<Datasource> datasourceList = new ArrayList<>();
-            datasourceList.add(createdDatasource);
-            dryRunOpsMap.put(queryType.name(), datasourceList);
-        }
+        dryRunOpsMap.computeIfAbsent(queryType.name(), k -> new ArrayList<>()).add(createdDatasource);
     }
 }